Support writing DatabaseULog to file #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermankolden
force-pushed
the
dbulog-writing
branch
from
9c6029f
to
af28fc6
Compare
Previously we couldn't use == to compare ulogs, so we had to do __dict__ comparison manually in tests. We should just add such comparison as default, since two ULog objects that have the same data should be considered equal.
Writing DatabaseULog to file doesn't work, so we add a test which finds errors we can fix.
If DatabaseULog is lazy loaded it doesn't have data, so it will fail if trying to write to file.
DatabaseULog.write_ulog complained about wrong value types during struct packing.
hermankolden
force-pushed
the
dbulog-writing
branch
from
af28fc6
to
c6cbd33
Compare
There were lost in pyulog.2.sql, so the DB is very slow for large databases. NB: Applying this migration will take a while for large databases.
bkueng
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling DatabaseULog.write_ulog didn't work before, now it does.
I guess the comparison commit isn't directly related to DatabaseULog writing, but I included it since it made the write_ulog tests a little more understandable.
I noticed some indexes in the DB were missing from a previous migration so I added them too